From: Daniel P. Berrangé Date: Wed, 22 Jan 2020 11:42:18 +0000 (+0000) Subject: src: stop using O_DIRECTORY in resctrl X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=18dca21a32e9;p=libvirt.git src: stop using O_DIRECTORY in resctrl The O_DIRECTORY flag causes open() to return an error if the filename is a directory. There's no obvious reason why resctrl needs to use this, while the rest of libvirt code does not. Removing it avoids build issues on platforms where O_DIRECTORY is not defined, once we remove GNULIB. Reviewed-by: Pavel Hrdina Signed-off-by: Daniel P. Berrangé --- diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 684d2ce398..e9bcdb44b1 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -455,7 +455,7 @@ VIR_ONCE_GLOBAL_INIT(virResctrl); static int virResctrlLockWrite(void) { - int fd = open(SYSFS_RESCTRL_PATH, O_DIRECTORY | O_CLOEXEC); + int fd = open(SYSFS_RESCTRL_PATH, O_RDWR | O_CLOEXEC); if (fd < 0) { virReportSystemError(errno, "%s", _("Cannot open resctrl"));