From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 12 Oct 2015 14:37:15 +0000 (+0200)
Subject: libvirt-domain: Drop virDomainMigrateCheckNotLocal attribute
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=179d92c8481b2229edbfb233614328e08ab79dfc;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git

libvirt-domain: Drop virDomainMigrateCheckNotLocal attribute

Our apibuild.py script does not cope with ATTRIBUTE_NONNULL:

Parse Error: parsing function type, ')' expected
Got token  ('name', 'char')
Last token:  ('name', 'char')
Token queue:  [('op', '*'), ('name', 'dconnuri'), ('sep', ')')]
Line 3297 end:
Makefile:2441: recipe for target '../../docs/apibuild.py.stamp' failed

Let's drop it. Moreover, up until e17ae3ccc2dbc1400 where it was
introduced we did not really care about NULL-ity of dconnuri. And
moreover the ATTRIBUTE_NONNULL merely checks for static calls
over NULL, it won't catch the dynamic ones, where a NULL is
passed by a variable at runtime.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index e6c8604e4..6e1aacdd9 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -3293,7 +3293,7 @@ virDomainMigrateVersion3Params(virDomainPtr domain,
 }
 
 
-static int ATTRIBUTE_NONNULL(1)
+static int
 virDomainMigrateCheckNotLocal(const char *dconnuri)
 {
     virURIPtr tempuri = NULL;