From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 4 Aug 2016 07:20:31 +0000 (+0200)
Subject: securityselinuxlabeltest: Prefer virGetLastErrorMessage() over virGetLastError
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=1758ee4a94f8d92daaa71aabd2f05c14f98c987e;p=libvirt.git

securityselinuxlabeltest: Prefer virGetLastErrorMessage() over virGetLastError

At the beginning of the test, some preparation work is done. For
instance new virSecurityManager is created. If this fails for
whatever reason, we try to fetch the latest error and print the
error message contained in it. However, if there's a bug in our
code and no error is reported, this approach will lead to crash,
while with virGetLastErrorMessage() it won't.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/tests/securityselinuxlabeltest.c b/tests/securityselinuxlabeltest.c
index 7d5544b730..4c0f427e63 100644
--- a/tests/securityselinuxlabeltest.c
+++ b/tests/securityselinuxlabeltest.c
@@ -354,9 +354,8 @@ mymain(void)
     if (!(mgr = virSecurityManagerNew("selinux", "QEMU",
                                       VIR_SECURITY_MANAGER_DEFAULT_CONFINED |
                                       VIR_SECURITY_MANAGER_PRIVILEGED))) {
-        virErrorPtr err = virGetLastError();
         VIR_TEST_VERBOSE("Unable to initialize security driver: %s\n",
-                err->message);
+                         virGetLastErrorMessage());
         return EXIT_FAILURE;
     }