From: longtao.pang Date: Wed, 13 May 2015 03:36:40 +0000 (+0800) Subject: Move the code for setting memory size into prep() X-Git-Tag: wip.libvirt-v3-base~158 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=155bdb33b7c0227c1fb8b49ee54610c7a466b59b;p=people%2Fliuw%2Fosstest.git Move the code for setting memory size into prep() Move the code for setting memory size from outside into prep(), where these $ram_mb operations are only used; And in next patch, for L2 guest installation, $ram_mb will be overridden by a runvar value, which needs $gho in scope. This is pure code motion. No functional change. Signed-off-by: longtao.pang Acked-by: Ian Campbell --- diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install index f3629e1..ea2d1ad 100755 --- a/ts-debian-hvm-install +++ b/ts-debian-hvm-install @@ -166,6 +166,18 @@ sub prep () { target_putfilecontents_root_stash($ho, 10, preseed(), $preseed_file_path); + # If host has >8G free memory, create a guest with 4G memory to catch + # any error that triggers cross 4G boundary + my $host_freemem_mb = host_get_free_memory($ho); + my $ram_minslop = 100; + my $ram_lots = 5000; + if ($host_freemem_mb > $ram_lots * 2 + $ram_minslop) { + $ram_mb = $ram_lots; + } else { + $ram_mb = 768; + } + logm("Host has $host_freemem_mb MB free memory, setting guest memory size to $ram_mb MB"); + more_prepareguest_hvm($ho,$gho, $ram_mb, $disk_mb, OnReboot => 'preserve', Bios => $r{bios}, @@ -183,18 +195,6 @@ sub prep () { }); } -# If host has >8G free memory, create a guest with 4G memory to catch -# any error that triggers cross 4G boundary -my $host_freemem_mb = host_get_free_memory($ho); -my $ram_minslop = 100; -my $ram_lots = 5000; -if ($host_freemem_mb > $ram_lots * 2 + $ram_minslop) { - $ram_mb = $ram_lots; -} else { - $ram_mb = 768; -} -logm("Host has $host_freemem_mb MB free memory, setting guest memory size to $ram_mb MB"); - if (!$stage) { prep(); guest_create($gho);