From: Guido Günther <agx@sigxcpu.org>
Date: Thu, 13 Aug 2015 12:19:50 +0000 (+0200)
Subject: Check if qemu-bridge-helper exists and is executable
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=151ba022939dad1e562c4156cb62e7a3ade6a7f5;p=libvirt.git

Check if qemu-bridge-helper exists and is executable

Otherwise the error is just

    error: Failed to create domain from test1.xml
    error: failed to retrieve file descriptor for interface: Transport endpoint is not connected

since we don't get a sensible error after the fork.
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 5a92ad4b2e..c5a4fdf09a 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -295,6 +295,12 @@ static int qemuCreateInBridgePortWithHelper(virQEMUDriverConfigPtr cfg,
         return -1;
     }
 
+    if (!virFileIsExecutable(cfg->bridgeHelperName)) {
+        virReportSystemError(errno, _("'%s' is not a suitable bridge helper"),
+                             cfg->bridgeHelperName);
+        return -1;
+    }
+
     cmd = virCommandNew(cfg->bridgeHelperName);
     if (flags & VIR_NETDEV_TAP_CREATE_VNET_HDR)
         virCommandAddArgFormat(cmd, "--use-vnet");