From: Yann Dirson <yann.dirson@vates.fr>
Date: Tue, 21 Nov 2023 12:31:14 +0000 (+0100)
Subject: netlink: remove redundant traces
X-Git-Tag: 0.3.0~14^2~5
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=140317fb423a0051f7e5e3f62cf076e5ba953384;p=xen-guest-agent.git

netlink: remove redundant traces

* separately logging header+nlas just duplicates with less info the
  full message log
* the full message itself is already available from netlink crate, as now
  described in the README

Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
---

diff --git a/src/collector_net_netlink.rs b/src/collector_net_netlink.rs
index 5bda209..396cfb0 100644
--- a/src/collector_net_netlink.rs
+++ b/src/collector_net_netlink.rs
@@ -64,7 +64,6 @@ impl NetworkSource {
         let mut nl_response = self.handle.request(nl_msg, SocketAddr::new(0, 0))?;
         // Handle response
         while let Some(packet) = nl_response.next().await {
-            log::trace!("<<< {:?}", packet);
             if let NetlinkMessage{payload: NetlinkPayload::InnerMessage(msg), ..} = packet {
                 events.push(netevent_from_rtnetlink(&msg)?);
             }
@@ -81,7 +80,6 @@ impl NetworkSource {
         let mut nl_response = self.handle.request(nl_msg, SocketAddr::new(0, 0))?;
         // Handle response
         while let Some(packet) = nl_response.next().await {
-            log::trace!("<<< {:?}", packet);
             if let NetlinkMessage{payload: NetlinkPayload::InnerMessage(msg), ..} = packet {
                 events.push(netevent_from_rtnetlink(&msg)?);
             }
@@ -93,7 +91,6 @@ impl NetworkSource {
     pub fn stream(&mut self) -> impl Stream<Item = io::Result<NetEvent>> + '_ {
         try_stream! {
             while let Some((message, _)) = self.messages.next().await {
-                log::trace!("rtnetlink change message - {message:?}");
                 if let NetlinkMessage{payload: NetlinkPayload::InnerMessage(msg), ..} = message {
                     yield netevent_from_rtnetlink(&msg)?;
                 }
@@ -131,7 +128,6 @@ fn netevent_from_rtnetlink(nl_msg: &RtnlMessage) -> io::Result<NetEvent> {
 
 fn nl_linkmessage_decode(msg: &LinkMessage) -> io::Result<(NetInterface, String)> {
     let LinkMessage{header, nlas, ..} = msg;
-    log::trace!("{header:?} {nlas:?}");
 
     // extract fields of interest
     let mut address_bytes: Option<&Vec<u8>> = None;
@@ -158,7 +154,6 @@ fn nl_linkmessage_decode(msg: &LinkMessage) -> io::Result<(NetInterface, String)
 
 fn nl_addressmessage_decode(msg: &AddressMessage) -> io::Result<(NetInterface, IpAddr)> {
     let AddressMessage{header, nlas, ..} = msg;
-    log::trace!("{header:?} {nlas:?}");
 
     // extract fields of interest
     let mut address_bytes: Option<&Vec<u8>> = None;