From: Andrew Cooper Date: Tue, 27 Sep 2022 15:47:08 +0000 (+0100) Subject: Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=13a7c0074ac8fb31f6c0485429b7a20a1946cb22;p=people%2Ftklengyel%2Fxen.git Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS This breaks all Clang builds, as demostrated by Gitlab CI. Contrary to the description in ecd6b9759919, -no-pie is not even an option passed to the linker. GCC's actual behaviour is to inhibit the passing of -pie to the linker, as well as selecting different cr0 artefacts to be linked. EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to gain such a usecase. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Tested-by: Stefano Stabellini Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") --- diff --git a/Config.mk b/Config.mk index 000e57e57b..69af1e60d4 100644 --- a/Config.mk +++ b/Config.mk @@ -188,7 +188,7 @@ endif APPEND_LDFLAGS += $(foreach i, $(APPEND_LIB), -L$(i)) APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i)) -EMBEDDED_EXTRA_CFLAGS := -fno-pie -no-pie -fno-stack-protector -fno-stack-protector-all +EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles