From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 24 Mar 2016 14:56:16 +0000 (+0100)
Subject: qemu: command: Split up formatting of -numa and memory devices
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=13a4ec678fe55e9d4a65eb8d1263486899842386;p=libvirt.git

qemu: command: Split up formatting of -numa and memory devices

They recently were extracted to a separate function. They don't belong
together though. Since -numa formatting is pretty compact, move it to
the main function and rename qemuBuildNumaCommandLine to
qemuBuildMemoryDeviceCommandLine.
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 8545533aeb..2d0ca97caf 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -7182,18 +7182,14 @@ qemuBuildNumaArgStr(virQEMUDriverConfigPtr cfg,
 
 
 static int
-qemuBuildNumaCommandLine(virCommandPtr cmd,
-                         virQEMUDriverConfigPtr cfg,
-                         virDomainDefPtr def,
-                         virQEMUCapsPtr qemuCaps,
-                         virBitmapPtr nodeset)
+qemuBuildMemoryDeviceCommandLine(virCommandPtr cmd,
+                                 virQEMUDriverConfigPtr cfg,
+                                 virDomainDefPtr def,
+                                 virQEMUCapsPtr qemuCaps,
+                                 virBitmapPtr nodeset)
 {
     size_t i;
 
-    if (virDomainNumaGetNodeCount(def->numa) &&
-        qemuBuildNumaArgStr(cfg, def, cmd, qemuCaps, nodeset) < 0)
-        return -1;
-
     /* memory hotplug requires NUMA to be enabled - we already checked
      * that memory devices are present only when NUMA is */
     for (i = 0; i < def->nmems; i++) {
@@ -9260,7 +9256,11 @@ qemuBuildCommandLine(virConnectPtr conn,
     if (qemuBuildIOThreadCommandLine(cmd, def, qemuCaps) < 0)
         goto error;
 
-    if (qemuBuildNumaCommandLine(cmd, cfg, def, qemuCaps, nodeset) < 0)
+    if (virDomainNumaGetNodeCount(def->numa) &&
+        qemuBuildNumaArgStr(cfg, def, cmd, qemuCaps, nodeset) < 0)
+        goto error;
+
+    if (qemuBuildMemoryDeviceCommandLine(cmd, cfg, def, qemuCaps, nodeset) < 0)
         goto error;
 
     virUUIDFormat(def->uuid, uuid);