From: Wei Liu Date: Wed, 25 Feb 2015 14:56:00 +0000 (+0000) Subject: libxl: fix off-by-one error in JSON parser X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=1391ca3bfa6555deefa3df620e1aa824652329f5;p=people%2Fgdunlap%2Fxen.git libxl: fix off-by-one error in JSON parser We need a sentinel slot in the generated libxl_key_value_list. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Acked-by: Ian Campbell --- diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c index ceb014a323..98335b05b2 100644 --- a/tools/libxl/libxl_json.c +++ b/tools/libxl/libxl_json.c @@ -247,7 +247,7 @@ int libxl__key_value_list_parse_json(libxl__gc *gc, const libxl__json_object *o, maps = libxl__json_object_get_map(o); size = maps->count * 2; - kvl = *p = libxl__calloc(NOGC, size, sizeof(char *)); + kvl = *p = libxl__calloc(NOGC, size+1, sizeof(char *)); for (i = 0; i < maps->count; i++) { int idx = i * 2;