From: John Ferlan <jferlan@redhat.com>
Date: Sat, 15 Nov 2014 13:09:53 +0000 (-0500)
Subject: qemu: Resolve Coverity UNINIT
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=121fc4f9f331cc85cfc4c85c99b2cbf7ea5c53ac;p=libvirt.git

qemu: Resolve Coverity UNINIT

For some reason, commit id '72b4151f' triggered a Coverity uninitialized
'reply' variable check when referenced within the for loop.

It seems Coverity doesn't know that flags will have to be either AFFECT_LIVE
or AFFECT_CONFIG after the virDomainLiveConfigHelperMethod call.

By adding a "sa_assert()" to confirm that fact, Coverity is happy again.
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 9b19629a02..a84fd479e7 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17000,6 +17000,8 @@ qemuDomainGetBlockIoTune(virDomainPtr dom,
     if (virDomainLiveConfigHelperMethod(caps, driver->xmlopt, vm, &flags,
                                         &persistentDef) < 0)
         goto endjob;
+    sa_assert((flags & VIR_DOMAIN_AFFECT_LIVE) ||
+              (flags & VIR_DOMAIN_AFFECT_CONFIG));
 
     if (flags & VIR_DOMAIN_AFFECT_LIVE) {
         /* If the VM is running, we can check if the current VM can use