From: Christian Gmeiner <christian.gmeiner@gmail.com>
Date: Sat, 1 Sep 2012 15:13:03 +0000 (+0200)
Subject: Change return values for vp_setup() and dc_setup()
X-Git-Tag: rel-1.7.2~71
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=11ebc7d3de51100eb213e6c0707bc7f3f06670f7;p=seabios.git

Change return values for vp_setup() and dc_setup()

There is no reason to have a return code for vp_setup()
and dc_setup(). So get rid of them.

Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---

diff --git a/vgasrc/geodevga.c b/vgasrc/geodevga.c
index d44b7c1..f323f4a 100644
--- a/vgasrc/geodevga.c
+++ b/vgasrc/geodevga.c
@@ -149,7 +149,7 @@ static u32 framebuffer_size(void)
 /* Set up the dc (display controller) portion of the geodelx
 *  The dc provides hardware support for VGA graphics.
 */
-static int dc_setup(void)
+static void dc_setup(void)
 {
     u32 dc_fb;
 
@@ -179,8 +179,6 @@ static int dc_setup(void)
     /* update VBE variables */
     SET_VGA(VBE_framebuffer, geode.fb);
     SET_VGA(VBE_total_memory, fb_size / 1024 / 64); // number of 64K blocks
-    
-    return 0;
 }
 
 /* Setup the vp (video processor) portion of the geodelx
@@ -189,7 +187,7 @@ static int dc_setup(void)
 *  The High Mem Access virtual register is used to  configure the
 *   pci mmio bar from 16bit friendly io space.
 */
-int vp_setup(void)
+static void vp_setup(void)
 {
     u32 reg;
 
@@ -216,8 +214,6 @@ int vp_setup(void)
     geode_memWrite(geode.vp + VP_DCFG, ~0,VP_CRT_EN+VP_HSYNC_EN+VP_VSYNC_EN+VP_DAC_BL_EN+VP_CRT_SKEW);
     reg = geode_memRead(geode.vp + VP_DCFG);
     dprintf(1,"VP_SETUP VP_DCFG=0x%08x\n",reg);
-
-    return 0;
 }
 
 static u8 geode_crtc_01[] VAR16 = {
@@ -315,8 +311,8 @@ int geodevga_init(void)
     dprintf(1, "dc addr: 0x%08x\n", geode.dc);
     dprintf(1, "vp addr: 0x%08x\n", geode.vp);
     
-    ret |= vp_setup();
-    ret |= dc_setup();
+    vp_setup();
+    dc_setup();
 
-    return ret;
+    return 0;
 }