From: Ján Tomko Date: Mon, 24 Oct 2016 15:35:32 +0000 (+0200) Subject: virQEMUCapsReset: also clear out hostCPUModel X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=1157678f81182f8fb1b88c6e61593f087becbc27;p=libvirt.git virQEMUCapsReset: also clear out hostCPUModel After succesfully reading an outdated caps cache from disk, calling virQEMUCapsReset did not properly clear out the calculated host CPU model. This lead to a memory leak when the host CPU model pointer was overwritten later in virQEMUCapsNewForBinaryInternal. Introduced by commit 68c70118. --- diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 9132469f06..130f1dba96 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3430,6 +3430,9 @@ virQEMUCapsReset(virQEMUCapsPtr qemuCaps) VIR_FREE(qemuCaps->gicCapabilities); qemuCaps->ngicCapabilities = 0; + + virCPUDefFree(qemuCaps->hostCPUModel); + qemuCaps->hostCPUModel = NULL; }