From: Vladimir Sementsov-Ogievskiy Date: Tue, 30 Jul 2019 16:32:50 +0000 (+0300) Subject: block/backup: disable copy_range for compressed backup X-Git-Tag: qemu-xen-4.13.0-rc1~19^2 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=110571be4e70ac015628e76d2731f96dd8d1998c;p=qemu-xen.git block/backup: disable copy_range for compressed backup Enabled by default copy_range ignores compress option. It's definitely unexpected for user. It's broken since introduction of copy_range usage in backup in 9ded4a011496. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20190730163251.755248-3-vsementsov@virtuozzo.com Reviewed-by: John Snow Reviewed-by: Max Reitz Cc: qemu-stable@nongnu.org Signed-off-by: Max Reitz --- diff --git a/block/backup.c b/block/backup.c index 1ee271f9f1..b26c22c4b8 100644 --- a/block/backup.c +++ b/block/backup.c @@ -657,7 +657,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs, job->cluster_size = cluster_size; job->copy_bitmap = copy_bitmap; copy_bitmap = NULL; - job->use_copy_range = true; + job->use_copy_range = !compress; /* compression isn't supported for it */ job->copy_range_size = MIN_NON_ZERO(blk_get_max_transfer(job->common.blk), blk_get_max_transfer(job->target)); job->copy_range_size = MAX(job->cluster_size,