From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 22 Nov 2011 11:56:10 +0000 (+0100)
Subject: console: Fix qemu_default_pixelformat() for 24 bpp
X-Git-Tag: qemu-xen-4.3.0-rc1~1896^2~32
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=0eba62e03292ff91201358fd544cadfbff36f1bf;p=qemu-upstream-4.4-testing.git

console: Fix qemu_default_pixelformat() for 24 bpp

Falls through to 32 bpp.  Harmless, because the only difference is the
alpha component, and we're not using that.  Spotted by Coverity.

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---

diff --git a/console.c b/console.c
index ce0429df8..223f8fd9a 100644
--- a/console.c
+++ b/console.c
@@ -1688,6 +1688,7 @@ PixelFormat qemu_default_pixelformat(int bpp)
             pf.rbits = 8;
             pf.gbits = 8;
             pf.bbits = 8;
+            break;
         case 32:
             pf.rmask = 0x00FF0000;
             pf.gmask = 0x0000FF00;