From: John Ferlan Date: Fri, 4 Mar 2016 14:35:19 +0000 (-0500) Subject: locking: Use bit shift for flag values not constant values. X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=0e3e00a1838d8e0f94001f1e83dc477023c8ea8c;p=libvirt.git locking: Use bit shift for flag values not constant values. So far it hasn't bitten us, but if the next value wasn't 4, then the logic used to check flag bits would have issues. --- diff --git a/src/locking/lock_driver_lockd.h b/src/locking/lock_driver_lockd.h index baf346adaf..6931fe7425 100644 --- a/src/locking/lock_driver_lockd.h +++ b/src/locking/lock_driver_lockd.h @@ -23,8 +23,8 @@ # define __VIR_LOCK_DRIVER_LOCKD_H__ enum virLockSpaceProtocolAcquireResourceFlags { - VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_SHARED = 1, - VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_AUTOCREATE = 2, + VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_SHARED = (1 << 0), + VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_AUTOCREATE = (1 << 1), }; #endif /* __VIR_LOCK_DRIVER_LOCKD_H__ */