From: John Ferlan <jferlan@redhat.com>
Date: Wed, 27 Aug 2014 11:32:11 +0000 (-0400)
Subject: parallels: Resolve Coverity USE_AFTER_FREE
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=0da9a8a8bffc682b7a13c1d8d68744970d12a22c;p=libvirt.git

parallels: Resolve Coverity USE_AFTER_FREE

Coverity complains that calling virNetworkDefFree(def), then jumping
to the cleanup: label which calls virNetworkDefFree(def) could result
in a double_free.  Just remove the call from the if statement.
---

diff --git a/src/parallels/parallels_network.c b/src/parallels/parallels_network.c
index a45acdc080..f41c97f89c 100644
--- a/src/parallels/parallels_network.c
+++ b/src/parallels/parallels_network.c
@@ -226,10 +226,8 @@ parallelsLoadNetwork(parallelsConnPtr privconn, virJSONValuePtr jobj)
         goto cleanup;
     }
 
-    if (!(net = virNetworkAssignDef(&privconn->networks, def, false))) {
-        virNetworkDefFree(def);
+    if (!(net = virNetworkAssignDef(&privconn->networks, def, false)))
         goto cleanup;
-    }
     net->active = 1;
     net->autostart = 1;
     virNetworkObjUnlock(net);