From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 6 May 2021 15:02:50 +0000 (+0200)
Subject: virDomainAudioCommonParse: Fix parsing of 'format'
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=0bcd3eecbf4da276919934a065b7f369ee44a40f;p=libvirt.git

virDomainAudioCommonParse: Fix parsing of 'format'

Commit 38180f87f5b converted the code to use virXMLPropEnum unfaithfully
ommitting the check where 'format' must be non-zero when parsed from the
user.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ce0ffc60ef..d36ff536f4 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -13098,7 +13098,7 @@ virDomainAudioCommonParse(virDomainAudioIOCommon *def,
 
         if (virXMLPropEnum(settings, "format",
                            virDomainAudioFormatTypeFromString,
-                           VIR_XML_PROP_NONE, &def->format) < 0)
+                           VIR_XML_PROP_NONZERO, &def->format) < 0)
             return -1;
     }