From: John Ferlan <jferlan@redhat.com>
Date: Wed, 2 Mar 2016 18:59:37 +0000 (-0500)
Subject: util: Cleanup error path for virPolkitAgentCreate
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=0b36b0e9;p=libvirt.git

util: Cleanup error path for virPolkitAgentCreate

More fallout from changing to using virPolkitAgent and handling error
paths.  Needed to clear the 'cmd' once stored and of course add the
virCommandFree(cmd) in the error: label.
---

diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c
index 44f2328303..2038744404 100644
--- a/src/util/virpolkit.c
+++ b/src/util/virpolkit.c
@@ -182,6 +182,7 @@ virPolkitAgentCreate(void)
     if (VIR_ALLOC(agent) < 0)
         goto error;
     agent->cmd = cmd;
+    cmd = NULL;
 
     virCommandAddArgFormat(cmd, "%lld", (long long int) getpid());
     virCommandAddArg(cmd, "--notify-fd");
@@ -206,6 +207,7 @@ virPolkitAgentCreate(void)
     VIR_FORCE_CLOSE(pipe_fd[0]);
     VIR_FORCE_CLOSE(pipe_fd[1]);
     virPolkitAgentDestroy(agent);
+    virCommandFree(cmd);
     return NULL;
 }