From: Daniel Vetter Date: Tue, 12 Jan 2021 08:43:53 +0000 (+0100) Subject: drm/arc: Drop crtc check in arc_pgu_update X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=0a9422d279e9d07bfe070eedee482f1a43821802;p=people%2Fpauldu%2Flinux.git drm/arc: Drop crtc check in arc_pgu_update It's redundant, drm core guarantees that state->fb is set iff state->crtc is set. v2: I had a misconception about simple helpers here and thought they filter this out. They don't. Issue reported by Eugeniy. Acked-by: Thomas Zimmermann Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Alexey Brodkin Link: https://patchwork.freedesktop.org/patch/msgid/20210112084358.2771527-10-daniel.vetter@ffwll.ch --- diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c index 19accc5a2f93..bfd892a9fa3d 100644 --- a/drivers/gpu/drm/arc/arcpgu_crtc.c +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c @@ -135,7 +135,7 @@ static void arc_pgu_update(struct drm_simple_display_pipe *pipe, struct arcpgu_drm_private *arcpgu; struct drm_gem_cma_object *gem; - if (!pipe->plane.state->crtc || !pipe->plane.state->fb) + if (!pipe->plane.state->fb) return; arcpgu = pipe_to_arcpgu_priv(pipe);