From: Maxim Nestratov <mnestratov@parallels.com>
Date: Wed, 22 Apr 2015 15:25:50 +0000 (+0300)
Subject: parallels: don't forget to unlock domain after successful virDomainObjListFindByUUID... 
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=0898d818ee4bd14de8d4e13e2d1508f833c59db6;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git

parallels: don't forget to unlock domain after successful virDomainObjListFindByUUID call

Also a typo is fixed (s/detached/attached/)

Signed-off-by: Maxim Nestratov mnestratov@parallels.com
---

diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
index d135ecdec..662bb386d 100644
--- a/src/parallels/parallels_driver.c
+++ b/src/parallels/parallels_driver.c
@@ -1109,7 +1109,7 @@ static int parallelsDomainAttachDeviceFlags(virDomainPtr dom, const char *xml,
     privdom = virDomainObjListFindByUUID(privconn->domains, dom->uuid);
     if (privdom == NULL) {
         parallelsDomNotFoundError(dom);
-        goto cleanup;
+        return -1;
     }
 
     if (!(flags & VIR_DOMAIN_AFFECT_CONFIG)) {
@@ -1148,13 +1148,14 @@ static int parallelsDomainAttachDeviceFlags(virDomainPtr dom, const char *xml,
         break;
     default:
         virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
-                       _("device type '%s' cannot be detached"),
+                       _("device type '%s' cannot be attached"),
                        virDomainDeviceTypeToString(dev->type));
         break;
     }
 
     ret = 0;
  cleanup:
+    virObjectUnlock(privdom);
     return ret;
 }