From: Petr Matousek <pmatouse@redhat.com>
Date: Mon, 27 Oct 2014 11:41:44 +0000 (+0100)
Subject: vnc: sanitize bits_per_pixel from the client
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=080b7f3a6f11bb724926d9aab364c4f660960489;p=qemu-upstream-4.3-testing.git

vnc: sanitize bits_per_pixel from the client

bits_per_pixel that are less than 8 could result in accessing
non-initialized buffers later in the code due to the expectation
that bytes_per_pixel value that is used to initialize these buffers is
never zero.

To fix this check that bits_per_pixel from the client is one of the
values that the rfb protocol specification allows.

This is CVE-2014-7815.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>

[ kraxel: apply codestyle fix ]

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---

diff --git a/ui/vnc.c b/ui/vnc.c
index 04afcffc5..c548eddb2 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -1880,6 +1880,16 @@ static void set_pixel_format(VncState *vs,
         return;
     }
 
+    switch (bits_per_pixel) {
+    case 8:
+    case 16:
+    case 32:
+        break;
+    default:
+        vnc_client_error(vs);
+        return;
+    }
+
     vs->client_pf.rmax = red_max;
     vs->client_pf.rbits = hweight_long(red_max);
     vs->client_pf.rshift = red_shift;