From: Richard Henderson Date: Mon, 4 Apr 2022 06:49:06 +0000 (+0200) Subject: linux-user/ppc: Narrow type of ccr in save_user_regs X-Git-Tag: qemu-xen-4.17.0-rc4~12^2 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=0798da8df9fd917515c957ae918d6d979cf5f3fb;p=qemu-xen.git linux-user/ppc: Narrow type of ccr in save_user_regs Coverity warns that we shift a 32-bit value by N, and then accumulate it into a 64-bit type (target_ulong on ppc64). The ccr is always 8 * 4-bit fields, and thus is always a 32-bit quantity; narrow the type to avoid the warning. Fixes: Coverity CID 1487223 Signed-off-by: Richard Henderson Reviewed-by: Cédric Le Goater Message-Id: <20220401191643.330393-1-richard.henderson@linaro.org> Signed-off-by: Cédric Le Goater --- diff --git a/linux-user/ppc/signal.c b/linux-user/ppc/signal.c index ec0b9c0df3..ce5a4682cd 100644 --- a/linux-user/ppc/signal.c +++ b/linux-user/ppc/signal.c @@ -229,7 +229,7 @@ static void save_user_regs(CPUPPCState *env, struct target_mcontext *frame) { target_ulong msr = env->msr; int i; - target_ulong ccr = 0; + uint32_t ccr = 0; /* In general, the kernel attempts to be intelligent about what it needs to save for Altivec/FP/SPE registers. We don't care that