From: Stefan Berger <stefanb@linux.vnet.ibm.com>
Date: Wed, 6 Nov 2019 21:35:59 +0000 (-0500)
Subject: tpm: Require a response to have minimum size of a valid response header
X-Git-Tag: rel-1.13.0~10
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=0672bd3b6affd414ac8721686a0ed1bef8fd73b3;p=seabios.git

tpm: Require a response to have minimum size of a valid response header

Defend against a broken TPM 1.2 or TPM 2.0 that doesn't send at least
a full response header in the response but less than 10 bytes.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---

diff --git a/src/hw/tpm_drivers.c b/src/hw/tpm_drivers.c
index e4770b3..2b5753c 100644
--- a/src/hw/tpm_drivers.c
+++ b/src/hw/tpm_drivers.c
@@ -620,7 +620,8 @@ tpmhw_transmit(u8 locty, struct tpm_req_header *req,
         return -1;
 
     irc = td->readresp(respbuffer, respbufferlen);
-    if (irc != 0)
+    if (irc != 0 ||
+        *respbufferlen < sizeof(struct tpm_rsp_header))
         return -1;
 
     td->ready();