From: Eric Blake <eblake@redhat.com>
Date: Sat, 8 Oct 2011 02:56:00 +0000 (-0600)
Subject: qemu: silence Coverity false positive
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=0654d274e6fdc5c1b3d632665670b338957fc60d;p=libvirt.git

qemu: silence Coverity false positive

Coverity complained that 4 out of 5 callers to virJSONValueObjectGetBoolean
checked for errors.  But we documented that we don't care in this case.

* src/qemu/qemu_monitor_json.c (qemuMonitorJSONGetBlockInfo): Use
ignore_value.
---

diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index c4f8360e9d..3d383c825e 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -40,6 +40,7 @@
 #include "datatypes.h"
 #include "virterror_internal.h"
 #include "json.h"
+#include "ignore-value.h"
 
 #define VIR_FROM_THIS VIR_FROM_QEMU
 
@@ -1418,7 +1419,8 @@ int qemuMonitorJSONGetBlockInfo(qemuMonitorPtr mon,
         /* Don't check for success here, because 'tray-open' is presented iff
          * medium is ejected.
          */
-        virJSONValueObjectGetBoolean(dev, "tray-open", &info->tray_open);
+        ignore_value(virJSONValueObjectGetBoolean(dev, "tray-open",
+                                                  &info->tray_open));
 
         break;
     }