From: Eric Blake <eblake@redhat.com>
Date: Tue, 18 Sep 2012 23:34:25 +0000 (-0600)
Subject: util: don't print free'd dmidecode path
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=03da89d14188ce27a6c7ad3b9b946d6e39802b0f;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git

util: don't print free'd dmidecode path

The path was freed before printing the error message, resulting in:
error : virSysinfoRead:773 : internal error Failed to execute command
(null)
But virCommandRun already gives a better error message.

* src/util/sysinfo.c (virSysinfoRead): Avoid overwriting error.
---

diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c
index 92c35395f..7f0a45b5c 100644
--- a/src/util/sysinfo.c
+++ b/src/util/sysinfo.c
@@ -767,12 +767,8 @@ virSysinfoRead(void) {
     cmd = virCommandNewArgList(path, "-q", "-t", "0,1,4,17", NULL);
     VIR_FREE(path);
     virCommandSetOutputBuffer(cmd, &outbuf);
-    if (virCommandRun(cmd, NULL) < 0) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("Failed to execute command %s"),
-                       path);
+    if (virCommandRun(cmd, NULL) < 0)
         goto cleanup;
-    }
 
     if (VIR_ALLOC(ret) < 0)
         goto no_memory;