From: Keir Fraser Date: Tue, 7 Dec 2010 18:37:31 +0000 (+0000) Subject: x86: remove BUG_ON() from QUIRK_IOAPIC_*_REGSEL handler X-Git-Tag: 4.0.2-rc1~35 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=02df0617fdadeed7e5fe6802079ac649754c12f0;p=people%2Fvhanquez%2Fxen.git x86: remove BUG_ON() from QUIRK_IOAPIC_*_REGSEL handler Since (non-pvops, 32-bit only up to 2.6.27) Linux would report "BAD" unconditionally on all SiS chipset versions (it only looks for a PCI device at 0000:00:00.0 with SiS as the vendor), we must not crash if the report on a 64-bit hypervisor doesn't match the #define (which is zero). While we could honor the quirk indication even on 64-bit, it doesn't seem worthwhile, as there's no evidence that newer SiS chipsets (supporting 64-bit CPUs) are actually affected. This should also address bug 1687 (mis-reported, however, afaict). Signed-off-by: Jan Beulich xen-unstable changeset: 22466:bfd13358b8bf xen-unstable date: Tue Dec 07 18:32:04 2010 +0000 --- diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c index e2b4fe015..9bb952d3f 100644 --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -192,7 +192,10 @@ ret_t do_platform_op(XEN_GUEST_HANDLE(xen_platform_op_t) u_xenpf_op) dprintk(XENLOG_INFO, "Domain 0 says that IO-APIC REGSEL is %s\n", sis_apic_bug ? "bad" : "good"); #else - BUG_ON(sis_apic_bug != (quirk_id == QUIRK_IOAPIC_BAD_REGSEL)); + if ( sis_apic_bug != (quirk_id == QUIRK_IOAPIC_BAD_REGSEL) ) + dprintk(XENLOG_WARNING, + "Domain 0 thinks that IO-APIC REGSEL is %s\n", + sis_apic_bug ? "good" : "bad"); #endif break; default: