From: Zhang Chen Date: Wed, 31 Oct 2018 00:50:15 +0000 (+0800) Subject: net/filter-rewriter.c: Fix coverity static analysis issue X-Git-Tag: qemu-xen-4.13.0-rc1~542^2 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=013a62020a92f371555c67342424f2f944b62be4;p=qemu-xen.git net/filter-rewriter.c: Fix coverity static analysis issue The original code just follow the TCP state diagram, but in this case, we can skip the TCPS_TIME_WAIT state to simplify the implementation. Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c index bb8f4d93b1..2e26839bc2 100644 --- a/net/filter-rewriter.c +++ b/net/filter-rewriter.c @@ -155,12 +155,13 @@ static int handle_primary_tcp_pkt(RewriterState *rf, * Active close step 2. */ if (conn->tcp_state == TCPS_FIN_WAIT_1) { - conn->tcp_state = TCPS_TIME_WAIT; /* * For simplify implementation, we needn't wait 2MSL time * in filter rewriter. Because guest kernel will track the * TCP status and wait 2MSL time, if client resend the FIN * packet, guest will apply the last ACK too. + * So, we skip the TCPS_TIME_WAIT state here and go straight + * to TCPS_CLOSED state. */ conn->tcp_state = TCPS_CLOSED; g_hash_table_remove(rf->connection_track_table, key);