Remove pointless bool conversions

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>

diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 029b12fa3b0ccf68aa4133ecf59bc4a7dad8a5c0..cad6c9ce421ab7331bdcc04634695f865400eeda 100644 (file)
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -873,7 +873,7 @@ libxlDomainCleanup(libxlDriverPrivate *driver,
         priv->deathW = NULL;
     }
 
-    if (!!g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCallback)
+    if (g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCallback)
         driver->inhibitCallback(false, driver->inhibitOpaque);
 
     /* Release auto-allocated graphics ports */

diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index 205ab96ebb4ac5b143b6c6aa64a06320b51b10f1..dc6f4fc03cea71cdf50125ac1677d8879a6c7f37 100644 (file)
--- a/src/lxc/lxc_process.c
+++ b/src/lxc/lxc_process.c
@@ -203,7 +203,7 @@ static void virLXCProcessCleanup(virLXCDriver *driver,
     vm->pid = 0;
     vm->def->id = -1;
 
-    if (!!g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCallback)
+    if (g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCallback)
         driver->inhibitCallback(false, driver->inhibitOpaque);
 
     virLXCDomainReAttachHostDevices(driver, vm->def);

diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c
index 26072ec26e16d61b35f8c740532cf61872b1d9f6..e65dbb93d9a17e5237c12527cfa4de0361cb2794 100644 (file)
--- a/src/nwfilter/nwfilter_dhcpsnoop.c
+++ b/src/nwfilter/nwfilter_dhcpsnoop.c
@@ -588,7 +588,7 @@ virNWFilterSnoopReqPut(virNWFilterSnoopReq *req)
     if (!req)
         return;
 
-    if (!!g_atomic_int_dec_and_test(&req->refctr)) {
+    if (g_atomic_int_dec_and_test(&req->refctr)) {
         /*
          * delete the request:
          * - if we don't find req on the global list anymore
@@ -743,7 +743,7 @@ virNWFilterSnoopReqLeaseDel(virNWFilterSnoopReq *req,
  skip_instantiate:
     g_free(ipl);
 
-    ignore_value(!!g_atomic_int_dec_and_test(&virNWFilterSnoopState.nLeases));
+    ignore_value(g_atomic_int_dec_and_test(&virNWFilterSnoopState.nLeases));
     return ret;
 }
 
@@ -1004,7 +1004,7 @@ static void virNWFilterDHCPDecodeWorker(void *jobdata, void *opaque)
                        _("Instantiation of rules failed on interface '%1$s'"),
                        req->binding->portdevname);
     }
-    ignore_value(!!g_atomic_int_dec_and_test(job->qCtr));
+    ignore_value(g_atomic_int_dec_and_test(job->qCtr));
 }
 
 /*
@@ -1388,7 +1388,7 @@ virNWFilterDHCPSnoopThread(void *req0)
             pcap_close(pcapConf[i].handle);
     }
 
-    ignore_value(!!g_atomic_int_dec_and_test(&virNWFilterSnoopState.nThreads));
+    ignore_value(g_atomic_int_dec_and_test(&virNWFilterSnoopState.nThreads));
 
     return;
 }

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 0e9e1a8efccf5cbdd8d7c023667a1b0300872e27..72fc750d282f5b67f633a9144552e47fadec27a5 100644 (file)
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -8711,7 +8711,7 @@ void qemuProcessStop(virQEMUDriver *driver,
     if (priv->eventThread)
         g_object_unref(g_steal_pointer(&priv->eventThread));
 
-    if (!!g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCallback)
+    if (g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCallback)
         driver->inhibitCallback(false, driver->inhibitOpaque);
 
     /* Clear network bandwidth */

diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
index 8b6a950a0186d7944a8619978e08cae14582e228..e0be8e758287c316ce2c6216e9a7cd51d9c49b15 100644 (file)
--- a/tools/virsh-snapshot.c
+++ b/tools/virsh-snapshot.c
@@ -780,8 +780,8 @@ virshSnapshotFilter(vshControl *ctl, virDomainSnapshotPtr snapshot,
         return -1;
     }
     if (STREQ(state, "disk-snapshot")) {
-        return !!((flags & VIR_DOMAIN_SNAPSHOT_LIST_DISK_ONLY) &&
-                  (flags & VIR_DOMAIN_SNAPSHOT_LIST_EXTERNAL));
+        return (flags & VIR_DOMAIN_SNAPSHOT_LIST_DISK_ONLY) &&
+               (flags & VIR_DOMAIN_SNAPSHOT_LIST_EXTERNAL);
     }
 
     if (!(flags & VIR_DOMAIN_SNAPSHOT_LIST_INTERNAL))