]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu_firmware: only set nfeatures on success
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Wed, 5 Jun 2019 10:31:01 +0000 (12:31 +0200)
committerJán Tomko <jtomko@redhat.com>
Wed, 26 Jun 2019 07:24:09 +0000 (09:24 +0200)
The field is set just before returning on success.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_firmware.c

index f3d89d000d1a149e6fab8094f633c27311afd53d..bf29b10b9a7ddcf2434af0cfe360adeed16ca841 100644 (file)
@@ -592,8 +592,6 @@ qemuFirmwareFeatureParse(const char *path,
     if (VIR_ALLOC_N(features, nfeatures) < 0)
         return -1;
 
-    fw->nfeatures = nfeatures;
-
     for (i = 0; i < nfeatures; i++) {
         virJSONValuePtr item = virJSONValueArrayGet(featuresJSON, i);
         const char *tmpStr = virJSONValueGetString(item);