]> xenbits.xensource.com Git - people/liuw/mini-os.git/commitdiff
mini-os: fixed format string error in unbind_evtchn
authorThomas Leonard <talex5@gmail.com>
Thu, 26 Jun 2014 11:28:20 +0000 (12:28 +0100)
committerIan Campbell <ian.campbell@citrix.com>
Fri, 27 Jun 2014 12:38:33 +0000 (13:38 +0100)
Would crash if HYPERVISOR_event_channel_op returned an error code.
The other changes in this commit are just fixing indentation.

Signed-off-by: Thomas Leonard <talex5@gmail.com>
Acked-by: Ian Campbell <ian.cammpbell@citrix.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
events.c

index d60630bfaf502f5f2723b062b904e2ae166c5295..f708cb4d88ef20e4fb28a02e22501ad1de7f6607 100644 (file)
--- a/events.c
+++ b/events.c
@@ -109,24 +109,23 @@ evtchn_port_t bind_evtchn(evtchn_port_t port, evtchn_handler_t handler,
 
 void unbind_evtchn(evtchn_port_t port )
 {
-       struct evtchn_close close;
+    struct evtchn_close close;
     int rc;
 
-       if ( ev_actions[port].handler == default_handler )
-               printk("WARN: No handler for port %d when unbinding\n", port);
-       mask_evtchn(port);
-       clear_evtchn(port);
+    if ( ev_actions[port].handler == default_handler )
+        printk("WARN: No handler for port %d when unbinding\n", port);
+    mask_evtchn(port);
+    clear_evtchn(port);
 
-       ev_actions[port].handler = default_handler;
-       wmb();
-       ev_actions[port].data = NULL;
-       clear_bit(port, bound_ports);
+    ev_actions[port].handler = default_handler;
+    wmb();
+    ev_actions[port].data = NULL;
+    clear_bit(port, bound_ports);
 
-       close.port = port;
-       rc = HYPERVISOR_event_channel_op(EVTCHNOP_close, &close);
+    close.port = port;
+    rc = HYPERVISOR_event_channel_op(EVTCHNOP_close, &close);
     if ( rc )
-        printk("WARN: close_port %s failed rc=%d. ignored\n", port, rc);
-        
+        printk("WARN: close_port %d failed rc=%d. ignored\n", port, rc);
 }
 
 evtchn_port_t bind_virq(uint32_t virq, evtchn_handler_t handler, void *data)