CHROMIUM: drm/exynos: fb: Don't take reference when mapping fb's gem objects

The fb itself already takes a reference for all of its gem objects when
it is created, and releases them last when it is destroyed.  Taking an
additional reference when the gem objects are mapped into device memory,
which only happens when the fb is created, seems redundant.

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
BUG=chromium-os:37097
TEST=builds clean; sanity check on device

Change-Id: I63643e974a8cf7d04d32b96bebd5dad4cc281ba8
Reviewed-on: https://gerrit.chromium.org/gerrit/40448
Commit-Queue: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c
index c2dc5429b64487c764a219c6dcded1d25c602987..4dfe38772696e313ce397745a63995adf79c4617 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
@@ -50,8 +50,6 @@ static int exynos_drm_fb_map(struct exynos_drm_fb *exynos_fb)
                return -ENOMEM;
        }
 
-       drm_gem_object_reference(obj);
-
        ret = dma_map_sg(obj->dev->dev,
                         buf->sgt->sgl,
                         buf->sgt->orig_nents,
@@ -86,8 +84,6 @@ static void exynos_drm_fb_unmap(struct exynos_drm_fb *exynos_fb)
                     buf->sgt->sgl,
                     buf->sgt->orig_nents,
                     DMA_BIDIRECTIONAL);
-
-       drm_gem_object_unreference_unlocked(obj);
 }
 
 void exynos_drm_fb_release(struct kref *kref)