]> xenbits.xensource.com Git - libvirt.git/commitdiff
conf: Clean up virDomainHostdevDefNew()
authorAndrea Bolognani <abologna@redhat.com>
Tue, 27 Jun 2017 08:28:22 +0000 (10:28 +0200)
committerAndrea Bolognani <abologna@redhat.com>
Fri, 21 Jul 2017 15:03:44 +0000 (17:03 +0200)
Follow the same style as other similar functions.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
src/conf/domain_conf.c

index 84da9e4d51ebbd780d2d5e67b60d5e926e7c25af..9276cd90bbda206c66230b6f18f640d09f784dd4 100644 (file)
@@ -2434,13 +2434,13 @@ void virDomainVideoDefFree(virDomainVideoDefPtr def)
 virDomainHostdevDefPtr
 virDomainHostdevDefNew(virDomainXMLOptionPtr xmlopt)
 {
-    virDomainHostdevDefPtr def = NULL;
+    virDomainHostdevDefPtr def;
 
-    if (VIR_ALLOC(def) < 0 ||
-        VIR_ALLOC(def->info) < 0) {
-        VIR_FREE(def);
+    if (VIR_ALLOC(def) < 0)
         return NULL;
-    }
+
+    if (VIR_ALLOC(def->info) < 0)
+        goto error;
 
     if (xmlopt &&
         xmlopt->privateData.hostdevNew &&