qemuBuildCommandLine: Remove 'flags' argument

The flags are not used for anything.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 5cc16860204ccbb812ab1ee5099d3dff86967f13..9b9d9b1ab3f3bc9d70148652d8c63a1f8f2683d7 100644 (file)
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -10400,8 +10400,7 @@ qemuBuildCommandLine(virDomainObj *vm,
                      virDomainMomentObj *snapshot,
                      virNetDevVPortProfileOp vmop,
                      size_t *nnicindexes,
-                     int **nicindexes,
-                     unsigned int flags)
+                     int **nicindexes)
 {
     size_t i;
     char uuid[VIR_UUID_STRING_BUFLEN];
@@ -10412,8 +10411,8 @@ qemuBuildCommandLine(virDomainObj *vm,
     virDomainDef *def = vm->def;
     virQEMUCaps *qemuCaps = priv->qemuCaps;
 
-    VIR_DEBUG("Building qemu commandline for def=%s(%p) migrateURI=%s snapshot=%p vmop=%d flags=0x%x",
-              def->name, def, migrateURI, snapshot, vmop, flags);
+    VIR_DEBUG("Building qemu commandline for def=%s(%p) migrateURI=%s snapshot=%p vmop=%d",
+              def->name, def, migrateURI, snapshot, vmop);
 
     if (qemuBuildCommandLineValidate(driver, def) < 0)
         return NULL;

diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h
index 087ab52ee5d41f734fbf1cada749cc884023c56c..2bb4984656d201fd8d191154522c583f7cf72a49 100644 (file)
--- a/src/qemu/qemu_command.h
+++ b/src/qemu/qemu_command.h
@@ -48,8 +48,7 @@ virCommand *qemuBuildCommandLine(virDomainObj *vm,
                                  virDomainMomentObj *snapshot,
                                  virNetDevVPortProfileOp vmop,
                                  size_t *nnicindexes,
-                                 int **nicindexes,
-                                 unsigned int flags);
+                                 int **nicindexes);
 
 /* Generate the object properties for pr-manager */
 virJSONValue *qemuBuildPRManagerInfoProps(virStorageSource *src);

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5f4990b09c21c7bcbbcca1719237debf21e1d107..2533e22c382f12e9709fbf01345d412a887cf9e4 100644 (file)
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -6390,7 +6390,7 @@ static char *qemuConnectDomainXMLToNative(virConnectPtr conn,
     if (qemuConnectDomainXMLToNativePrepareHost(vm) < 0)
         return NULL;
 
-    if (!(cmd = qemuProcessCreatePretendCmdBuild(vm, NULL, 0)))
+    if (!(cmd = qemuProcessCreatePretendCmdBuild(vm, NULL)))
         return NULL;
 
     return virCommandToString(cmd, false);

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index d50cf2e6be32f46293464caeede54c07924acd9a..cabec71c1e2a09eb24f28a4fdfeb206f32583f68 100644 (file)
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -7448,7 +7448,7 @@ qemuProcessLaunch(virConnectPtr conn,
     if (!(cmd = qemuBuildCommandLine(vm,
                                      incoming ? "defer" : NULL,
                                      snapshot, vmop,
-                                     &nnicindexes, &nicindexes, 0)))
+                                     &nnicindexes, &nicindexes)))
         goto cleanup;
 
     if (incoming && incoming->fd != -1)
@@ -7945,16 +7945,14 @@ qemuProcessCreatePretendCmdPrepare(virQEMUDriver *driver,
 
 virCommand *
 qemuProcessCreatePretendCmdBuild(virDomainObj *vm,
-                                 const char *migrateURI,
-                                 unsigned int flags)
+                                 const char *migrateURI)
 {
     return qemuBuildCommandLine(vm,
                                 migrateURI,
                                 NULL,
                                 VIR_NETDEV_VPORT_PROFILE_OP_NO_OP,
                                 NULL,
-                                NULL,
-                                flags);
+                                NULL);
 }
 
 

diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h
index 2387fcdcdc4c7b36a9b97823ef18d5cb22ae143e..9866d2bf35c64b085d3293b02cef6a2137b7e932 100644 (file)
--- a/src/qemu/qemu_process.h
+++ b/src/qemu/qemu_process.h
@@ -98,8 +98,7 @@ int qemuProcessCreatePretendCmdPrepare(virQEMUDriver *driver,
                                        unsigned int flags);
 
 virCommand *qemuProcessCreatePretendCmdBuild(virDomainObj *vm,
-                                             const char *migrateURI,
-                                             unsigned int flags);
+                                             const char *migrateURI);
 
 int qemuProcessInit(virQEMUDriver *driver,
                     virDomainObj *vm,

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 8a15904b980e279350abb60383acf3e2586bd2d1..bd581b8485b82dc4cd5ed902e6777bcd61ce344b 100644 (file)
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -484,7 +484,7 @@ testCompareXMLToArgvCreateArgs(virQEMUDriver *drv,
         }
     }
 
-    return qemuProcessCreatePretendCmdBuild(vm, migrateURI, 0);
+    return qemuProcessCreatePretendCmdBuild(vm, migrateURI);
 }