]> xenbits.xensource.com Git - unikraft/unikraft.git/commitdiff
plat/common: Remove explicit APIC IRQ ACKing from handlers
authorMichalis Pappas <michalis@unikraft.io>
Thu, 14 Sep 2023 13:51:46 +0000 (15:51 +0200)
committerRazvan Deaconescu <razvand@unikraft.io>
Fri, 20 Oct 2023 16:35:55 +0000 (19:35 +0300)
Now that the xPIC drivers provides a unified IRQ handling,
remove explicit APIC IRQ acknowledgment from handlers.

Notice: Picking individual commits in this PR will break the build.

Signed-off-by: Michalis Pappas <michalis@unikraft.io>
Reviewed-by: Marco Schlumpp <marco@unikraft.io>
Reviewed-by: Sergiu Moga <sergiu@unikraft.io>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1103

plat/common/lcpu.c

index 88e3c32c54b53e6331118c3c91f85e5402b03975..94ffcee640a8b2b17807d255ad00032bd704aec0 100644 (file)
 #include <limits.h>
 #include <errno.h>
 
-#ifdef CONFIG_ARCH_X86_64
-/* TODO: Remove when we have unified IRQ handling */
-#include <uk/intctlr/apic.h>
-#endif /* CONFIG_ARCH_X86_64 */
-
 /**
  * Array of LCPUs, one for every CPU in the system.
  *
@@ -296,21 +291,11 @@ static int lcpu_ipi_run_handler(void *args __unused)
        UK_ASSERT(lcpu_state_is_busy(this_lcpu->state));
        ukarch_dec(&this_lcpu->state);
 
-#ifdef CONFIG_ARCH_X86_64
-       /* TODO: Remove when we have unified IRQ handling */
-       apic_ack_interrupt();
-#endif /* CONFIG_ARCH_X86_64 */
-
        return 1;
 }
 
 static int lcpu_ipi_wakeup_handler(void *args __unused)
 {
-#ifdef CONFIG_ARCH_X86_64
-       /* TODO: Remove when we have unified IRQ handling */
-       apic_ack_interrupt();
-#endif /* CONFIG_ARCH_X86_64 */
-
        /* Nothing to do */
        return 1;
 }