]> xenbits.xensource.com Git - people/julieng/boot-wrapper-aarch64.git/commitdiff
Remove unnecessary ldr from boot wrapper
authorMark Rutland <mark.rutland@arm.com>
Thu, 20 Dec 2012 16:52:51 +0000 (16:52 +0000)
committerMark Rutland <mark.rutland@arm.com>
Wed, 5 Jun 2013 12:56:14 +0000 (13:56 +0100)
We currently do an ldr from GICC_CTLR to w0, then immediately overwrite
w0 with a mov. Reading the GICC_CTLR has no effect on the state of the
GIC, so there's no reason to do the ldr. It's also inconsistent with the
way we set the GICD_CTLR.

Fix this.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
boot.S

diff --git a/boot.S b/boot.S
index a1f25e2b5f4108fc41b654e767a5b5ef3209b01e..7c28e84b265ba5e0d60b1ec41be05750b79b0231 100644 (file)
--- a/boot.S
+++ b/boot.S
@@ -49,7 +49,6 @@ _start:
        str     w0, [x1], #4
 
 2:     ldr     x1, =GIC_CPU_BASE               // GICC_CTLR
-       ldr     w0, [x1]
        mov     w0, #3                          // EnableGrp0 | EnableGrp1
        str     w0, [x1]