]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
conf: explicitly initialize 'cpumask' variable
authorRoman Bogorodskiy <bogorodskiy@gmail.com>
Tue, 28 Apr 2015 04:26:44 +0000 (08:26 +0400)
committerRoman Bogorodskiy <bogorodskiy@gmail.com>
Tue, 28 Apr 2015 06:30:26 +0000 (10:30 +0400)
Build with clang fails with:

  CC       conf/libvirt_conf_la-domain_conf.lo
  conf/domain_conf.c:13377:9: error: variable 'cpumask' is used
  uninitialized whenever 'if' condition is true
  [-Werror,-Wsometimes-uninitialized]
      if (!(tmp = virXMLPropString(node, "cpuset"))) {
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and many other similar errors regarding the 'cpuset' variable.

Fix by explicitly initializing it with NULL.

src/conf/domain_conf.c

index 0b187205d545134c10aa72cedf57de5b80c94e2c..957221b72bd9d5b95dc7cbaed83920e0cf136806 100644 (file)
@@ -13342,7 +13342,7 @@ virDomainIOThreadPinDefParseXML(xmlNodePtr node,
 {
     int ret = -1;
     virDomainIOThreadIDDefPtr iothrid;
-    virBitmapPtr cpumask;
+    virBitmapPtr cpumask = NULL;
     xmlNodePtr oldnode = ctxt->node;
     unsigned int iothreadid;
     char *tmp = NULL;