]> xenbits.xensource.com Git - people/hx242/xen.git/commitdiff
libxl: Pointer on usage of libxl__domain_userdata_lock
authorAnthony PERARD <anthony.perard@citrix.com>
Tue, 19 Mar 2019 17:55:22 +0000 (17:55 +0000)
committerIan Jackson <ian.jackson@eu.citrix.com>
Thu, 19 Sep 2019 11:24:46 +0000 (12:24 +0100)
It is currently difficult to know how/when/why the userdata lock is
supposed to be used. Add some pointers to the hotplug comments.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/libxl_internal.h

index a3e4b907b7c935393875f0c584478a4412e53737..03e086480ca3d530c617a33fd0c60e8e80bb387d 100644 (file)
@@ -4477,6 +4477,12 @@ void libxl__unlock_domain_userdata(libxl__domain_userdata_lock *lock);
  * data store. The registry entry in libxl private data store
  * is "libxl-json".
  * Caller must hold user data lock.
+ *
+ * Other names used for this lock throughout the libxl code are json_lock,
+ * libxl__domain_userdata_lock, "libxl-json", data store lock.
+ *
+ * See the comment for libxl__ao_device, and "Algorithm for handling device
+ * removal", for information about using the libxl-json lock / json_lock.
  */
 int libxl__get_domain_configuration(libxl__gc *gc, uint32_t domid,
                                     libxl_domain_config *d_config);