]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Fix deadlock if create qemuProcessReconnect thread failed
authorWang Yechao <wang.yechao255@zte.com.cn>
Fri, 21 Sep 2018 04:35:11 +0000 (12:35 +0800)
committerJohn Ferlan <jferlan@redhat.com>
Sat, 22 Sep 2018 11:11:22 +0000 (07:11 -0400)
Use the new qemuDomainRemoveInactiveJobLocked to remove the
@obj during the virDomainObjListForEach call which holds a
lock on the domain object list.

Signed-off-by: Wang Yechao <wang.yechao255@zte.com.cn>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/qemu/qemu_process.c

index f9a01daee78a4e601eea143fb7b184378813cf8b..711db105be22356553325384564e18aa67a8ea8d 100644 (file)
@@ -8033,7 +8033,7 @@ qemuProcessReconnectHelper(virDomainObjPtr obj,
          */
         qemuProcessStop(src->driver, obj, VIR_DOMAIN_SHUTOFF_FAILED,
                         QEMU_ASYNC_JOB_NONE, 0);
-        qemuDomainRemoveInactiveJob(src->driver, obj);
+        qemuDomainRemoveInactiveJobLocked(src->driver, obj);
 
         virDomainObjEndAPI(&obj);
         virNWFilterUnlockFilterUpdates();