]> xenbits.xensource.com Git - unikraft/unikraft.git/commitdiff
plat/kvm: Fix Kconfig dependency warning on Firecracker
authorMichalis Pappas <michalis@unikraft.io>
Tue, 24 Sep 2024 15:55:14 +0000 (17:55 +0200)
committerUnikraft Bot <monkey@unikraft.io>
Mon, 30 Sep 2024 09:13:51 +0000 (09:13 +0000)
Fix dependency warnings about VIRTIO_MMIO on Firecracker when no devices
are selected.

> WARNING: unmet direct dependencies detected for VIRTIO_MMIO_LINUX_COMPAT_CMDLINE
>   Depends on [n]: LIBVIRTIO_MMIO [=n]
>   Selected by [y]:
>   - KVM_VMM_FIRECRACKER [=y] && <choice> && (ARCH_X86_64 [=y] || ARCH_ARM_64 [=n])
>
> WARNING: unmet direct dependencies detected for VIRTIO_MMIO_LINUX_COMPAT_CMDLINE
>   Depends on [n]: LIBVIRTIO_MMIO [=n]
>   Selected by [y]:
>   - KVM_VMM_FIRECRACKER [=y] && <choice> && (ARCH_X86_64 [=y] || ARCH_ARM_64 [=n])

Checkpatch-Ignore: COMMIT_LOG_LONG_LINE
Signed-off-by: Michalis Pappas <michalis@unikraft.io>
Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Reviewed-by: Razvan Deaconescu <razvand@unikraft.io>
Reviewed-by: Thassilo Schulze <thassilo@thasso.xyz>
Approved-by: Simon Kuenzer <simon@unikraft.io>
GitHub-Closes: #1504

plat/kvm/Config.uk

index 330851d6c8aba346bbc5e0a7a60b28477e7b409c..484efb7a74ab80ff984268f9b6b3470f1d2750ed 100644 (file)
@@ -111,7 +111,7 @@ config KVM_VMM_FIRECRACKER
        select KVM_BOOT_PROTO_LXBOOT
        select HAVE_MMIO
        select HAVE_RANDOM
-       select VIRTIO_MMIO_LINUX_COMPAT_CMDLINE
+       select VIRTIO_MMIO_LINUX_COMPAT_CMDLINE if LIBVIRTIO_MMIO
        imply LIBUKCONSOLE_NS16550
        imply LIBUKCONSOLE_NS16550_EARLY_CONSOLE
        imply LIBUKCONSOLE_NS16550_COM1 if ARCH_X86_64