]> xenbits.xensource.com Git - people/dariof/qemu-xen.git/commitdiff
tpm: tpm_spapr: Exit on TPM backend failures
authorStefan Berger <stefanb@linux.vnet.ibm.com>
Tue, 7 Jul 2020 20:16:24 +0000 (16:16 -0400)
committerStefan Berger <stefanb@linux.vnet.ibm.com>
Wed, 15 Jul 2020 18:57:33 +0000 (14:57 -0400)
Exit on TPM backend failures in the same way as the TPM CRB and TIS device
models do. With this change we now get an error report when the backend
did not start up properly:

error: internal error: qemu unexpectedly closed the monitor:
2020-07-07T12:49:28.333928Z qemu-system-ppc64: tpm-emulator: \
  TPM result for CMD_INIT: 0x101 operation failed

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20200707201625.4177419-2-stefanb@linux.vnet.ibm.com

hw/tpm/tpm_spapr.c

index cb4dfd1e6a778e79b84f2ba762b3d43c97256912..8288ab0a15baef1b2cfca8c52c2c57774172476a 100644 (file)
@@ -306,7 +306,10 @@ static void tpm_spapr_reset(SpaprVioDevice *dev)
                             TPM_SPAPR_BUFFER_MAX);
 
     tpm_backend_reset(s->be_driver);
-    tpm_spapr_do_startup_tpm(s, s->be_buffer_size);
+
+    if (tpm_spapr_do_startup_tpm(s, s->be_buffer_size) < 0) {
+        exit(1);
+    }
 }
 
 static enum TPMVersion tpm_spapr_get_version(TPMIf *ti)