]> xenbits.xensource.com Git - libvirt.git/commitdiff
virISCSIDirectReportLuns: Drop ClearVols
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 28 Feb 2019 16:43:57 +0000 (17:43 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Sat, 16 Mar 2019 06:50:51 +0000 (07:50 +0100)
In bf5cf610f206d5d54 I've fixed a problem where iscsi-direct
backend was reporting only the last LUN. The fix consisted of
moving virStoragePoolObjClearVols() one level up. However, as it
turns out, storage driver already calls it before calling
refreshPool callback (which is
virStorageBackendISCSIDirectRefreshPool() in this case).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
src/storage/storage_backend_iscsi_direct.c

index fc161e6833cd6395261a5ab5a87622129628455f..6283a2836b11de330bd5b721e294c3f9a128f11c 100644 (file)
@@ -375,7 +375,6 @@ virISCSIDirectReportLuns(virStoragePoolObjPtr pool,
 
     def->capacity = 0;
     def->allocation = 0;
-    virStoragePoolObjClearVols(pool);
     for (i = 0; i < list->num; i++) {
         if (virISCSIDirectRefreshVol(pool, iscsi, list->luns[i], portal) < 0)
             goto cleanup;