]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
vl: Assert drive_new() does not fail in default_drive()
authorMarkus Armbruster <armbru@redhat.com>
Wed, 17 Oct 2018 08:26:56 +0000 (10:26 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 19 Oct 2018 12:51:34 +0000 (14:51 +0200)
If creating (empty) default drives fails, it's a bug.  Therefore,
assert() is more appropriate than exit(1).

Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20181017082702.5581-33-armbru@redhat.com>

vl.c

diff --git a/vl.c b/vl.c
index 7cd35d2c37c0fefade1247e76bf367483d2d5f3c..fbbae766d575d0f0273d1b2890dc08cec6fe76fd 100644 (file)
--- a/vl.c
+++ b/vl.c
@@ -1156,9 +1156,7 @@ static void default_drive(int enable, int snapshot, BlockInterfaceType type,
     }
 
     dinfo = drive_new(opts, type);
-    if (!dinfo) {
-        exit(1);
-    }
+    assert(dinfo);
     dinfo->is_default = true;
 
 }