]> xenbits.xensource.com Git - people/aperard/linux-chromebook.git/commitdiff
CHROMIUM: power: sbs: Warning on register read failure
authorSimon Glass <sjg@chromium.org>
Sat, 2 Feb 2013 05:51:15 +0000 (21:51 -0800)
committerChromeBot <chrome-bot@google.com>
Sun, 10 Feb 2013 14:55:29 +0000 (06:55 -0800)
Warn when we fail to read from the battery.

BUG=chrome-os-partner:10617
TEST=build and boot to kernel prompt on snow
Disconnect battery and see that we start getting kernel warnings.

Change-Id: I6ad787be5bc4937df6bbcfe6f0af5a4b3ea91272
Reviewed-on: https://gerrit.chromium.org/gerrit/42574
Commit-Queue: Simon Glass <sjg@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
drivers/power/sbs-battery.c

index 61832f3f61a875a20d57a170cb61fb7051b3142c..8bb0715d63b9a03d20fa0816445e1baa3f4bf1e9 100644 (file)
@@ -503,8 +503,10 @@ static int sbs_get_battery_capacity(struct i2c_client *client,
                return mode;
 
        ret = sbs_read_word_data(client, sbs_data[reg_offset].addr);
-       if (ret < 0)
+       if (ret < 0) {
+               pr_warn("Failed to read word data\n");
                return ret;
+       }
 
        if (psp == POWER_SUPPLY_PROP_CAPACITY) {
                /* sbs spec says that this can be >100 %