]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
Fix memory leak in QEMU QMP capabilities initialization
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 4 Dec 2012 13:16:07 +0000 (13:16 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Thu, 13 Dec 2012 14:45:53 +0000 (14:45 +0000)
The qemuCapsInitQMP method never frees the QEMU 'package'
version string.

src/qemu/qemu_capabilities.c

index 98e65f16c0075bde5675df3039a51d87f5f8b807..4ebba042f5bac96dfead94e6e5f01fb4b7234e9d 100644 (file)
@@ -2298,7 +2298,7 @@ qemuCapsInitQMP(qemuCapsPtr caps,
     virCommandPtr cmd = NULL;
     qemuMonitorPtr mon = NULL;
     int major, minor, micro;
-    char *package;
+    char *package = NULL;
     int status = 0;
     virDomainChrSourceDef config;
     char *monarg = NULL;
@@ -2442,6 +2442,7 @@ cleanup:
     virCommandFree(cmd);
     VIR_FREE(monarg);
     VIR_FREE(monpath);
+    VIR_FREE(package);
 
     if (pidfile) {
         char ebuf[1024];