]> xenbits.xensource.com Git - people/dwmw2/xen.git/commitdiff
x86/crash: fix kexec transition breakage
authorIgor Druzhinin <igor.druzhinin@citrix.com>
Fri, 19 Jul 2019 13:07:48 +0000 (14:07 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 22 Jul 2019 17:02:24 +0000 (18:02 +0100)
Following 6ff560f7f ("x86/SMP: don't try to stop already stopped CPUs")
an incorrect condition was placed into kexec transition path
leaving crashing CPU always online breaking kdump kernel entering.
Correct it by unifying the condition with smp_send_stop().

Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
xen/arch/x86/crash.c

index f9772dc2ab857ba8558f4f25db55c6e435caa170..a9f3e1890c5a1b4966b0c46f9758ac6e135d1180 100644 (file)
@@ -169,7 +169,7 @@ static void nmi_shootdown_cpus(void)
      */
     iommu_crash_shutdown();
 
-    if ( num_online_cpus() > 1 )
+    if ( cpu_online(cpu) )
     {
         __stop_this_cpu();