]> xenbits.xensource.com Git - libvirt.git/commitdiff
tests: Link mocks with libvirt.so
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 15 May 2018 06:58:33 +0000 (08:58 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 15 May 2018 12:02:52 +0000 (14:02 +0200)
In a lot of our mocks (if not all of them) we use our internal
APIs (e.g. VIR_ALLOC). So far, we're relying on test binary that
links with the mock to drag in libvirt.so. Well, this works only
partially. Firstly, whatever binary we execute from tests will
fail (e.g. as Martin reported on the list ./qemucapsprobe fails
to execute qemu). Secondly, if there's a program that tries to
validate linking (like valgrind is doing) it fails because of
unresolved symbols.

Because of that we have to link our mocks with libvirt.so.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
tests/Makefile.am

index 621480dd0c0fdddb0f04da505eec067d26e52d76..ac92190845b433e027ab9f27ca2313b961bc0f49 100644 (file)
@@ -81,7 +81,8 @@ LDADDS = \
        ../src/libvirt.la
 
 MOCKLIBS_LIBS = \
-       $(GNULIB_LIBS)
+       $(GNULIB_LIBS) \
+       ../src/libvirt.la
 
 EXTRA_DIST = \
        .valgrind.supp \