]> xenbits.xensource.com Git - libvirt.git/commitdiff
security: dac: remove leftover virPCIDeviceFree
authorJán Tomko <jtomko@redhat.com>
Thu, 18 Feb 2021 13:10:10 +0000 (14:10 +0100)
committerJán Tomko <jtomko@redhat.com>
Thu, 18 Feb 2021 16:14:47 +0000 (17:14 +0100)
The switch to g_auto left this one call behind.

Reported by Coverity.

Fixes: 4ab0d1844a1e60def576086edc8b2c3775e7c10d
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/security/security_dac.c

index 00eeae0d275bb59c34fae22c740cb41f75ff21b8..11f6c5c3da21653aeed3e3e00312c2ccb811a97f 100644 (file)
@@ -1430,10 +1430,9 @@ virSecurityDACRestoreHostdevLabel(virSecurityManagerPtr mgr,
         if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
             g_autofree char *vfioGroupDev = virPCIDeviceGetIOMMUGroupDev(pci);
 
-            if (!vfioGroupDev) {
-                virPCIDeviceFree(pci);
+            if (!vfioGroupDev)
                 return -1;
-            }
+
             ret = virSecurityDACRestoreFileLabelInternal(mgr, NULL,
                                                          vfioGroupDev, false);
         } else {