]> xenbits.xensource.com Git - libvirt.git/commitdiff
tests: Add SELINUX_LIBS to fix viridentitytest linker bug
authorJulio Faracco <jcfaracco@gmail.com>
Fri, 24 Oct 2014 12:33:52 +0000 (10:33 -0200)
committerEric Blake <eblake@redhat.com>
Fri, 24 Oct 2014 18:01:10 +0000 (12:01 -0600)
In a clean build system (Ubuntu 14.04), the viridentitytest failed to compile.
Even if all the SELINUX libraries and depedencies are installed. See the error
message below:

[...]
  CC       viridentitytest.o
  CCLD     viridentitytest
/usr/bin/ld: viridentitytest.o: undefined reference to symbol
                                                       'security_disable'
//lib/x86_64-linux-gnu/libselinux.so.1: error adding symbols: DSO missing
                                                           from command line
collect2: error: ld returned 1 exit status
make: *** [viridentitytest] Error 1

Simply adding the variable SELINUX_LIBS in viridentitytest rules of
Makefile.am to include SELINUX libraries into viridentitytest solved that
compilation issue.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
tests/Makefile.am

index 4c3d4efc7113ae1914affb055642357617edcf8e..7b22f9021b9a7f11e56b3e580de41ed353bbd500 100644 (file)
@@ -928,6 +928,7 @@ viridentitytest_SOURCES = \
        viridentitytest.c testutils.h testutils.c
 viridentitytest_LDADD = $(LDADDS)
 if WITH_SELINUX
+viridentitytest_LDADD += $(SELINUX_LIBS)
 viridentitytest_DEPENDENCIES = libsecurityselinuxhelper.la \
        ../src/libvirt.la
 endif WITH_SELINUX