]> xenbits.xensource.com Git - people/dariof/xen.git/commitdiff
firmware/shim: avoid mkdir error during Xen tree setup
authorJan Beulich <jbeulich@suse.com>
Wed, 14 Feb 2018 07:16:00 +0000 (08:16 +0100)
committerJan Beulich <jbeulich@suse.com>
Wed, 14 Feb 2018 07:16:00 +0000 (08:16 +0100)
"mkdir -p" reports a missing operand, as config/ has no subdirs. Oddly
enough this doesn't cause the whole command (and hence the build to
fail), despite the "set -e" now covering the entire set of commands -
perhaps a quirk of the relatively old bash I've seen this with (a few
simple experiments suggest that commands inside () producing a non-
success status would exit the inner shell, but not the outer one).

Add a dummy . argument to the invocation.

Suggested-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
tools/firmware/xen-dir/Makefile

index 04d3c936ea5f100c91e25555d12344a58d8b574e..7fd36a0e15f91019d97c24dea64dac252d3b9b3e 100644 (file)
@@ -22,7 +22,7 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE
                 (mkdir -p $(D)/$(d); \
                  cd $(D)/$(d); \
                  find $(XEN_ROOT)/$(d)/ -type d |\
-                       sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p);) \
+                       sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p .);) \
        $(foreach d, $(LINK_DIRS), \
                (cd $(XEN_ROOT); \
                 find $(d) ! -type l -type f \