]> xenbits.xensource.com Git - libvirt.git/commitdiff
virsh: Use proper helper for parsing XML in virshDumpXML
authorPeter Krempa <pkrempa@redhat.com>
Fri, 23 Sep 2022 12:42:18 +0000 (14:42 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 6 Oct 2022 08:54:25 +0000 (10:54 +0200)
Use virXMLParseStringCtxt instead of virXMLParseString since the code
requires a XPath context anyways.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tools/virsh-util.c

index 8a20f627a1cc7db14323af611c1d5782b321cb93..3c4a084441ed0a342e343d4ee2f9d13e7be355af 100644 (file)
@@ -457,14 +457,11 @@ virshDumpXML(vshControl *ctl,
     }
 
     oldblanks = xmlKeepBlanksDefault(0);
-    doc = virXMLParseString(xml, url);
+    doc = virXMLParseStringCtxt(xml, url, &ctxt);
     xmlKeepBlanksDefault(oldblanks);
     if (!doc)
         return false;
 
-    if (!(ctxt = virXMLXPathContextNew(doc)))
-        return false;
-
     if ((nnodes = virXPathNodeSet(xpath, ctxt, &nodes)) < 0) {
         return false;
     }